add conditional statement #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecat validation unchanged
mnoergaard
reviewed
Feb 15, 2024
There was a problem hiding this comment.
This looks good to me - I have asked @bendhouseart to carry out a few more tests also comparing with Turku's ecat2nii, so he might have additional feedback.
|
@mnoergaard actually needs to be the other way around -- all our phantoms seems calibrated ! |
|
It's beautiful > In ecat2nii (line 334)
Warning: it looks like the source data are already dose calibrated - ecat2nii is thus not scaling the data
> In ecat2nii (line 339) |
|
Alright, the Nii's produced by this look like they're scaling to the same range as the original ecats viewed in Vinci and as the outputs from Turku. Below is a comparison of the the outputs from a previous commit on this branch compared to the current status 2165535 done in freeview: 
Looks good to me 👍 |
bendhouseart
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ecat validation remains unchanged by adding this statement
📚 Documentation preview 📚: https://pet2bids--271.org.readthedocs.build/en/271/